No hand cursor for disabled button#286
Open
tomasfil wants to merge 1 commit intoKinnara:masterfrom
tomasfil:master
Open
No hand cursor for disabled button#286tomasfil wants to merge 1 commit intoKinnara:masterfrom tomasfil:master
tomasfil wants to merge 1 commit intoKinnara:masterfrom
tomasfil:master
Conversation
For default button style, there is no difference in visual compared to accent button. So at least change of cursor would help greatly.
|
I think even enabled buttons doesn't have hand cursor, and they are almost the same as enabled buttons, you only notice the absence of the hover effect when you hover it. |
|
I agree that there should be a visual difference to the button when disabled, this is typically by going greyscale and paler than the normal state. It seems to do this for text, but an other elements don't inherit Foreground within the button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For default button style, there is no difference in visual when disabled compared to visual of accent button. So at least change of cursor would help greatly for user experience.